Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-1.28] Backports for August 2024 #10673

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[Release-1.28] Backports for August 2024 #10673

merged 3 commits into from
Aug 6, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 5, 2024 •
edited
Loading

Proposed Changes

Backports:

Types of Changes

Verification

Testing

Linked Issues

#10639
#10635

User-Facing Change

Further Comments

@dereknola
Enhance E2E Hardened option (k3s-io#10558)
e5854fe 
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <derek.nola@suse.com>

* slim down hardened arguments

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Use higher QPS for secrets reencryption (k3s-io#10571)
e5789d1 
* Use higher QPS for secrets reencryption

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Allow Pprof and Superisor metrics in standalone mode (k3s-io#10576)
6ad9217 
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner August 5, 2024 17:07
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 35.78%. Comparing base (199d9ea) to head (6ad9217).

Files Patch % Lines
pkg/secretsencrypt/controller.go 0.00% 12 Missing ⚠️
pkg/agent/run.go 0.00% 6 Missing ⚠️
pkg/server/server.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (199d9ea) and HEAD (6ad9217). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (199d9ea) HEAD (6ad9217)
unittests 1 0
e2etests 7 6
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.28   #10673      +/-   ##
================================================
- Coverage         40.99%   35.78%   -5.22%     
================================================
  Files               179      162      -17     
  Lines             18471    14208    -4263     
================================================
- Hits               7572     5084    -2488     
+ Misses             9625     8129    -1496     
+ Partials           1274      995     -279
Flag Coverage Δ
e2etests 35.78% <0.00%> (-10.20%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 47f1d34 into k3s-io:release-1.28 Aug 6, 2024
29 checks passed
@dereknola dereknola deleted the slim_hard_128 branch August 12, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorsavian vitorsavian vitorsavian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dereknola @vitorsavian